Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: Improve dropdown menu #102109

Closed
night-lake opened this issue Jul 10, 2020 · 15 comments
Closed

Git: Improve dropdown menu #102109

night-lake opened this issue Jul 10, 2020 · 15 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@night-lake
Copy link

Currently, many options like push/pull are hidden in this menu.
image

This makes it way harder to find commonly used options. I propose that the common git actions are also included in the actual pane and not the menu.

@joaomoreno
Copy link
Member

Depends on #100172

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jul 12, 2020
@joaomoreno joaomoreno added this to the July 2020 milestone Jul 12, 2020
@night-lake
Copy link
Author

Not the same, mine is about adding things like push/pull/stash and commit options like Commit Staged (Ammend) in a more accessible area.

@joaomoreno joaomoreno changed the title Improve Git UI Git: Improve dropdown menu Jul 15, 2020
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Jul 31, 2020
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Aug 3, 2020
@ghiscoding
Copy link

ghiscoding commented Aug 3, 2020

This new feature display seems a little bit broken with the new insider version I got today, it's way off on the right, there's like a 100px offset between the submenu and its content. I couldn't find any opened issue referencing this new visual problem but it happens on all submenus (I'm on Windows).

Also is there a flag to disable this new view? I prefer the old view, since the new view requires (2x mouse positioning) first is to go over the "pull, push" submenu and second go on the command "push", while previous version is going straight to the command. I do push/pull every day and I find the extra step (mouse positioning) a bit annoying. It would be nice to choose which commands we want as submenu and which one we don't, but a simple flag for the old/new UI would be enough in my case.

image

image

@ghiscoding ghiscoding mentioned this issue Aug 3, 2020
3 tasks
annkamsk pushed a commit to annkamsk/vscode that referenced this issue Aug 3, 2020
@ejsmith
Copy link

ejsmith commented Aug 3, 2020

Yeah, I have the same issue with the sub-menu alignment. But more importantly, the most common commands have got to be at the top and not under a sub-menu because now I have to click more to get to a common action like doing a push or a rebase.

@ghiscoding
Copy link

Yes totally agree and I've mentioned that as well in my previous comment, we now have to do 2 mouse actions (positioning) instead of 1 and that bothers me as well. Hopefully there's a flag or options to customize it?
Waiting for Ms Team to reply on this :)

@joaomoreno
Copy link
Member

The submenu positioning was a separate workbench issue which just got resolved in master. I don't think a configuration flag is warranted to display the git menu: it was a big clutter of mess which lacked certain commands. With submenus we can organize commands better and add some missing ones without it looking like a kitchen sink. That sure comes at the cost of you sometimes going one extra level to get where you want to go, but that's expected. There are many other ways to run git commands without the mouse hassle: via F1 and via keyboard shortcuts.

@ejsmith
Copy link

ejsmith commented Aug 4, 2020

Don't you think that having some of the most commonly used commands at the top of the menu makes sense? It's great that the sub-menus allow it to be more organized and support more commands, but the most common ones should still be easily accessible without digging through the menus IMO.

@ejsmith
Copy link

ejsmith commented Aug 4, 2020

I have repositories checked out. I'm looking at them, but the top options in the menu that are the easiest to get to are for me to "Checkout to..." and "Clone". Sure seems like there are git actions that are a lot more frequently used than those when I'm already working with a repository. I'm sorry, but don't you think this is a bit ridiculous? I guess maybe this is not the final design and I'm jumping the gun on the criticism here, but I'm just giving my feedback which is what I think this Insiders channel is for.

image

@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 5, 2020
@joshunger
Copy link
Contributor

Ah man it is always tough to change habits. I'm wondering if there is a ux study which showed what menu people preferred? Do you have user data on which menu choices people frequently clicked on? Can you add a push button? Is there a follow up issue to fix @Senko-Dev original issue?

@ejsmith
Copy link

ejsmith commented Aug 6, 2020

It's not about changing habits. Checkout to... and Clone are now top level options on repos that I am already working with. Please tell me how that makes any sense? There are plenty of git commands that can be buried because they are rarely used, but push, pull, pull (rebase) and maybe stash and pop latest stash are going to be the most common commands when I am working with a repository.

Here is what GitKraken has as top level commands:
image

@joaomoreno joaomoreno added the on-release-notes Issue/pull request mentioned in release notes label Aug 7, 2020
@hellowhirl
Copy link

please bring back the "Push" button in the top menu... change is hard and I'm lazzz

@martin-braun
Copy link

I don't like that push and pull are hidden in a sub menu now, those are the most used commands and should be on top level.

@night-lake
Copy link
Author

Fuck it, time to GitHub Desktop.

@gjsjohnmurray
Copy link
Contributor

As a workaround I just published a simple extension.

@mheatleyTMN
Copy link

It's not about changing habits. Checkout to... and Clone are now top level options on repos that I am already working with. Please tell me how that makes any sense?

Agreed, burying common commands in slow flyout menus without a straightforward way to customize is just bad design. Closing related issues as "as designed" is bad customer service. Not everyone wants to keyboard their way to a git push, some of us like to do it differently.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

11 participants